Rewrite Inset Handling #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imashnake0
reviewed
Feb 24, 2025
navigation/src/main/kotlin/com/imashnake/animite/navigation/NavigationBar.kt
Outdated
Show resolved
Hide resolved
imashnake0
reviewed
Feb 24, 2025
app/src/main/kotlin/com/imashnake/animite/features/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
1 task
imashnake0
reviewed
Feb 26, 2025
app/src/main/kotlin/com/imashnake/animite/features/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
imashnake0
reviewed
Mar 1, 2025
| .padding(bottom = searchBarBottomPadding) | ||
| .navigationBarsPadding() | ||
| .consumeWindowInsets(PaddingValues(bottom = searchBarBottomPadding)) | ||
| .imePadding() |
There was a problem hiding this comment.
We shouldn't have to change this too much
imashnake0
reviewed
Mar 2, 2025
There was a problem hiding this comment.
gonna replace this with https://github.com/uragiristereo/Mikansei/blob/main/core/ui/src/main/java/com/uragiristereo/mikansei/core/ui/extension/PaddingValues.kt in a follow up PR
imashnake0
reviewed
Mar 2, 2025
| end = LocalPaddings.current.large | ||
| contentPadding = Paddings( | ||
| horizontal = LocalPaddings.current.large | ||
| ) + Paddings( |
imashnake0
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.Previously, we were relying on orientation values to handle some insets. This is NOT correct, and has even led to a few edge cases that weren't handled. I'm rewriting our inset handling to be orientation-agnostic.
Summary of changes:
landscapeCutoutPadding(very bad)Tested changes:
UI components do not overlap any system bars in any orientation or device configuration (this includes Foldables, and other unique form factors)